Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contracts] Simplify implementation declarations #31440

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented May 9, 2019

Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Nobody but us references these for now so we let's make them simpler asap.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone May 9, 2019

@fabpot

fabpot approved these changes May 9, 2019

@nicolas-grekas nicolas-grekas merged commit 7d51da3 into symfony:4.2 May 9, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 9, 2019

minor #31440 [Contracts] Simplify implementation declarations (nicola…
…s-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[Contracts] Simplify implementation declarations

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Nobody but us references these for now so we let's make them simpler asap.

Commits
-------

7d51da3 [Contracts] Simplify implementation declarations

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:contracts-implem branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.