Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Fix finding translator parent definition in compiler pass #31442

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
4 participants
@deguif
Copy link
Contributor

commented May 9, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Method ChildDefintion::getParent() returns a string, but here it is expected to return an object of class Definition in order to call getClass on it in the loop.

@deguif deguif changed the base branch from master to 4.2 May 9, 2019

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone May 9, 2019

@kbsali

kbsali approved these changes May 9, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Thank you @deguif.

@nicolas-grekas nicolas-grekas merged commit d261bb5 into symfony:4.2 May 11, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 11, 2019

bug #31442 [Validator] Fix finding translator parent definition in co…
…mpiler pass (deguif)

This PR was merged into the 4.2 branch.

Discussion
----------

[Validator] Fix finding translator parent definition in compiler pass

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Method `ChildDefintion::getParent()` returns a string, but here it is expected to return an object of class `Definition` in order to call `getClass` on it in the loop.

Commits
-------

d261bb5 Fix finding parent definition

@deguif deguif deleted the deguif:fix-parent-definition branch May 13, 2019

@fabpot fabpot referenced this pull request May 22, 2019

Merged

Release v4.3.0-BETA2 #31577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.