Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated usage of some Twig features #31456

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
3 participants
@fabpot
Copy link
Member

commented May 10, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
@fabpot

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

Tests will be fix with twigphp/Twig#2999

@fabpot fabpot force-pushed the fabpot:twig-dep-fix branch from 2156916 to b49ac82 May 10, 2019

@fabpot fabpot force-pushed the fabpot:twig-dep-fix branch from b49ac82 to 74afcd6 May 10, 2019

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone May 10, 2019

@nicolas-grekas
Copy link
Member

left a comment

(not on 3.4?)

@fabpot

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

@nicolas-grekas no occurrences on 3.4 :)

@fabpot fabpot merged commit 74afcd6 into symfony:4.2 May 10, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 10, 2019

bug #31456 Remove deprecated usage of some Twig features (fabpot)
This PR was merged into the 4.2 branch.

Discussion
----------

Remove deprecated usage of some Twig features

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

74afcd6 removed deprecated usage of some Twig features

@fabpot fabpot referenced this pull request May 22, 2019

Merged

Release v4.3.0-BETA2 #31577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.