Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MimeTypeExtensionGuesser.php #31464

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@ifaridjalilov
Copy link

commented May 10, 2019

Added mime type for aac (audio/x-hx-aac-adts)

Q A
Branch? master for features / 3.4, 4.2 or 4.3 for bug fixes
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
Update MimeTypeExtensionGuesser.php
Added mime type for aac (audio/x-hx-aac-adts)

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 11, 2019

@nicolas-grekas
Copy link
Member

left a comment

Thanks.
That's for 4.3? Or do we want this on 3.4?
src/Symfony/Component/Mime/MimeTypes.php should be updated also.

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

It could change the behavior of consuming apps, so I am for 4.3 and not 3.4

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Continued in #31565, thank you.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 21, 2019

nicolas-grekas added a commit that referenced this pull request May 23, 2019

bug #31565 [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts…
… (ifaridjalilov)

This PR was merged into the 4.3 branch.

Discussion
----------

[Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Replaces #31464

Commits
-------

67fbae1 [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.