Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Update WorkflowEvents typo #31469

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
3 participants
@noniagriconomie
Copy link
Contributor

commented May 10, 2019

Q A
Branch?
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Some little typo
Maybe to do for other branches?

@nicolas-grekas
Copy link
Member

left a comment

(this file has been added in 4.3)

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.3 May 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Thank you @noniagriconomie.

@nicolas-grekas nicolas-grekas force-pushed the noniagriconomie:patch-1 branch from 027b0d2 to 6583e5a May 11, 2019

@nicolas-grekas nicolas-grekas merged commit 6583e5a into symfony:4.3 May 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 11, 2019

minor #31469 [Workflow] Update WorkflowEvents typo (noniagriconomie)
This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #31469).

Discussion
----------

[Workflow] Update WorkflowEvents typo

| Q             | A
| ------------- | ---
| Branch?       |  <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Some little typo
Maybe to do for other branches?

Commits
-------

6583e5a Update WorkflowEvents.php

@noniagriconomie noniagriconomie deleted the noniagriconomie:patch-1 branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.