Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[Messenger] Add "non sendable" stamps #31471
Fixes a bug where Symfony serialization of the AmqpReceivedStamp sometimes caused problems.
It's still a mystery why the
I don't love making the removal the responsibility of the serializers, but it didn't work well anywhere else.
referenced this pull request
May 10, 2019
Moved implementation to a new
I've only added the new "non-sendable stamp interface" to 3 transport-specific "received" stamps. Generally speaking, I think that stamps should be sent, unless there is a clear reason otherwise. Allowing stamps to be sendable (the default) can make the messages bigger when being retried after failure. But they also allow for a really beautiful "history" as you can look at an Envelope and see exactly what happened to it over time.
Anyways, this is ready to go!