Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Fix doctrine tests #31473

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
7 participants
@weaverryan
Copy link
Member

commented May 10, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR not needed

Not sure why, but when passing in pdo, the Doctrine Connection::_conn property is a PDO instance and isn't wrapped. In the master branch of doctrine/dbal, they now check for this an throw an exception.

@nicolas-grekas has a PR in Doctrine for this (doctrine/dbal#3543), but I don't see any reason we shouldn't just avoid the pdo option entirely.

@alcaeus
Copy link
Contributor

left a comment

👍

@jwage

jwage approved these changes May 10, 2019

@chalasr
Copy link
Member

left a comment

Same :) Thanks

@Tobion

Tobion approved these changes May 11, 2019

@Tobion

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Good catch, thanks Ryan.

@Tobion Tobion merged commit a7cf3f9 into symfony:4.3 May 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

Tobion added a commit that referenced this pull request May 11, 2019

minor #31473 [Messenger] Fix doctrine tests (weaverryan)
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Fix doctrine tests

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | not needed

Not sure why, but when passing in `pdo`, the Doctrine `Connection::_conn` property is a PDO instance and isn't wrapped. In the master branch of `doctrine/dbal`, they now check for this an throw an exception.

@nicolas-grekas has a PR in Doctrine for this (doctrine/dbal#3543), but I don't see any reason we shouldn't just avoid the `pdo` option entirely.

Commits
-------

a7cf3f9 Fixing tests - passing pdo is not wrapped for some reason in dbal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.