Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Allow set 'None' on samesite cookie flag #31475

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
4 participants
@markitosgv
Copy link
Contributor

commented May 10, 2019

Allow set samesite cookie flag to 'None' value

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31467
License MIT

Google introduces new Chrome policy, marking all none setted samesite flag to 'Strict' by default. If you want to allow third party cookies you must set samesite flag to None.

This PR fixes #31467, allow to put samesite Cookie flag to None.

Allow set 'None' on samesite cookie flag
Allow set samesite cookie flag to 'None' value

@markitosgv markitosgv changed the title Allow set 'None' on samesite cookie flag [HttpFoundation] Allow set 'None' on samesite cookie flag May 10, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone May 11, 2019

@fabpot

fabpot approved these changes May 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Thank you @markitosgv.

@nicolas-grekas nicolas-grekas merged commit 8bac3d6 into symfony:3.4 May 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 11, 2019

bug #31475 [HttpFoundation] Allow set 'None' on samesite cookie flag …
…(markitosgv)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Allow set 'None' on samesite cookie flag

Allow set samesite cookie flag to 'None' value

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31467
| License       | MIT

Google introduces new Chrome policy, marking all none setted samesite flag to 'Strict' by default. If you want to allow third party cookies you must set samesite flag to None.

This PR fixes #31467, allow to put samesite Cookie flag to None.

Commits
-------

8bac3d6 Allow set 'None' on samesite cookie flag

@fabpot fabpot referenced this pull request May 22, 2019

Merged

Release v4.3.0-BETA2 #31577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.