Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyAccess] Add missing property to PropertyAccessor #31477

Merged
merged 1 commit into from May 12, 2019

Conversation

Projects
None yet
5 participants
@vudaltsov
Copy link
Contributor

commented May 11, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
@vudaltsov

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

Status: Needs Review

@Simperfit
Copy link
Contributor

left a comment

don't we have a test case for the exception ?

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone May 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the vudaltsov:property-accessor-fix branch from 5290750 to b1d3736 May 12, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Thank you @vudaltsov.

@nicolas-grekas nicolas-grekas merged commit b1d3736 into symfony:4.2 May 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 12, 2019

bug #31477 [PropertyAccess] Add missing property to PropertyAccessor …
…(vudaltsov)

This PR was squashed before being merged into the 4.2 branch (closes #31477).

Discussion
----------

[PropertyAccess] Add missing property to PropertyAccessor

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

b1d3736 [PropertyAccess] Add missing property to PropertyAccessor

@fabpot fabpot referenced this pull request May 22, 2019

Merged

Release v4.3.0-BETA2 #31577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.