Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] Fix some errors when using serialized deprecations #31478

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@l-vo
Copy link
Contributor

commented May 11, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

During the refactoring for #29211, some very minor problems seamed to appear. I created #31382 for fixing one of them but I forgot two others; sorry for that. Both problems occurs when using @runInSeparateProcess in tests too:

  • deprecation isSelf condition is inverted when using runInSeparateProcess
  • wrong trace stack is used to determine isIndirect state of the deprecation when using runInSeparateProcess

@l-vo l-vo changed the title Fix some errors when using serialized deprecations [WIP][PhpUnitBridge] Fix some errors when using serialized deprecations May 11, 2019

@l-vo l-vo referenced this pull request May 11, 2019

Merged

[PhpUnitBridge] Url encoded deprecations helper config #29211

7 of 7 tasks complete

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 12, 2019

@l-vo l-vo force-pushed the l-vo:fix_some_errors_when_using_serialized_deprecations branch 2 times, most recently from 3b6621c to 31b4188 May 15, 2019

@l-vo l-vo force-pushed the l-vo:fix_some_errors_when_using_serialized_deprecations branch from 31b4188 to 25da423 May 15, 2019

@l-vo l-vo changed the title [WIP][PhpUnitBridge] Fix some errors when using serialized deprecations [PhpUnitBridge] Fix some errors when using serialized deprecations May 15, 2019

@l-vo l-vo marked this pull request as ready for review May 15, 2019

@l-vo

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Tests fail, I think it's because they use the PhpUnitBridge of the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.