Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle][Form] The form data collector return serialized data #31502

Merged

Conversation

Projects
None yet
4 participants
@Simperfit
Copy link
Contributor

commented May 15, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31476
License MIT
Doc PR not needed

This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.

This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.

@fabpot

This comment has been minimized.

Copy link
Member

commented May 15, 2019

What about fixing the constraints between the Form component and WebProfileBundle instead?

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@fabpot What will happen on the existing application requiring already theses versions (so with the bug) ?

@fabpot

This comment has been minimized.

Copy link
Member

commented May 15, 2019

The bug will still be there I suppose... but that's the same with your fix... you need to update to get it. I prefer to avoid having too many specific code to support different versions, bumping min versions is usually what we do.

@xabbuh

This comment has been minimized.

Copy link
Member

commented May 15, 2019

What is the version we would have to require to not have to use this code?

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

That's what I'm looking into, need to search @xabbuh

@Simperfit Simperfit force-pushed the Simperfit:bugfix/form-collector-return-serialized-data branch from 04c86fa to f04f415 May 15, 2019

@Simperfit Simperfit requested review from dunglas, lyrixx, sroze and xabbuh as code owners May 15, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@fabpot I've added a conflict in the WebProfilerBundle to avoid using the Form component below 4.3 since there are no real dependencies between the two, WDYT ?

[WebProfilerBundle][Form] The form data collector return serialized o…
…bject when profiler bundle attends object

@Simperfit Simperfit force-pushed the Simperfit:bugfix/form-collector-return-serialized-data branch from f04f415 to 70fdafd May 15, 2019

@Simperfit Simperfit changed the base branch from 3.4 to 4.3 May 15, 2019

@xabbuh xabbuh added this to the 4.3 milestone May 15, 2019

@fabpot

fabpot approved these changes May 18, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Thank you @Simperfit.

@fabpot fabpot merged commit 70fdafd into symfony:4.3 May 18, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 18, 2019

bug #31502 [WebProfilerBundle][Form] The form data collector return s…
…erialized data (Simperfit)

This PR was merged into the 4.3 branch.

Discussion
----------

[WebProfilerBundle][Form] The form data collector return serialized data

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31476 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | not needed <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.

This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.

Commits
-------

70fdafd [WebProfilerBundle][Form] The form data collector return serialized object when profiler bundle attends object

@fabpot fabpot referenced this pull request May 22, 2019

Merged

Release v4.3.0-BETA2 #31577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.