Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Add new method for getting a possible ProxyDumper #31507

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Spea
Copy link
Contributor

commented May 15, 2019

Q A
Branch? master
Bug fix? no
New feature? yes (well only kind of, actually it is only a refactoring)
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

In order to use my own implementation of the ProxyDumper in my projects, I currently have to override the dumpContainer method where I just copy 99% of the code and then replace only this line:

$dumper->setProxyDumper(new ProxyDumper());

As this is not really sufficient and sometimes even breaks when the dumpContainer method was adjusted, I created a new method which returns the proxy dumper and can be overridden in child classes.

@nicolas-grekas
Copy link
Member

left a comment

I'm good with the proposal once, see comments.

Show resolved Hide resolved src/Symfony/Component/HttpKernel/Kernel.php Outdated
Show resolved Hide resolved src/Symfony/Component/HttpKernel/Kernel.php Outdated
Show resolved Hide resolved src/Symfony/Component/HttpKernel/Kernel.php Outdated

@Spea Spea force-pushed the Spea:proxy-dumper branch from a8edede to 54683af May 21, 2019

@Spea Spea force-pushed the Spea:proxy-dumper branch from 54683af to 3d7dcc3 May 21, 2019

@Spea

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@nicolas-grekas Addressed your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.