Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[routing][config] Allow patterns of resources to be excluded from config loading #31587

Open
wants to merge 16 commits into
base: 4.4
from

Conversation

Projects
None yet
4 participants
@tristanbes
Copy link

commented May 22, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? no
Fixed tickets #31516
License MIT
Doc PR not yet

The PR will fix the following RFC: #31516

Like resource loading for services, this PR offers a way to exclude patterns of resources like:

// config/routes/annotations.yaml
controllers:
    resource: ../../src/Controller/*
    type: annotation
    exclude: '../src/Controller/{DebugEmailController}.php'

All the annotation routes inside Controller/ will be loaded in this example except all the one present inside the Controller/DebugEmailController.php

Right now i'm waiting for:

  • feedbacks

The php and xml implementations are missing since I don't want to advance in the wrong direction without proper feedbacks.

@vudaltsov

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

If you change FileLoader in the Config component, you should test the new behavior in the Config component in the first place.

@vudaltsov

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Deprecations for 4.4 must be described in UPGRADE-4.4.md (create if it does not exist), BC breaks must be mentioned in UPGRADE-5.0.md. Duplicate this info in src/Symfony/Component/Config/CHANGELOG.md.

@tristanbes tristanbes marked this pull request as ready for review May 27, 2019

@tristanbes tristanbes force-pushed the tristanbes:feature/allow-exclude-controllers branch from fe50d64 to 3ffd4ee May 27, 2019

@tristanbes tristanbes changed the title [routing] Exclude patterns of resources to be excluded from route loading [routing][config] Allow patterns of resources to be excluded from config loading May 27, 2019

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.4 Jun 2, 2019

HttpKernel
----------

* The `DebugHandlersListener` class has been marked as `final`

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 6, 2019

Member

never merges in PRs, please rebase

This comment has been minimized.

Copy link
@tristanbes

@tristanbes tristanbes force-pushed the tristanbes:feature/allow-exclude-controllers branch from 0d61faa to 3ffd4ee Jun 6, 2019

@tristanbes tristanbes force-pushed the tristanbes:feature/allow-exclude-controllers branch from 3ffd4ee to af14114 Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.