Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnitBridge] Use a more appropriate group when deprecating mode #31721

Conversation

Projects
None yet
4 participants
@greg0ire
Copy link
Contributor

commented May 30, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.

Use a more appropriate group when deprecating mode
The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Thank you @greg0ire.

@nicolas-grekas nicolas-grekas merged commit 3a88f11 into symfony:4.3 May 30, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 30, 2019

bug #31721 [PHPUnitBridge] Use a more appropriate group when deprecat…
…ing mode (greg0ire)

This PR was merged into the 4.3 branch.

Discussion
----------

[PHPUnitBridge] Use a more appropriate group when deprecating mode

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.

Commits
-------

3a88f11 Use a more appropriate group when deprecating mode

@greg0ire greg0ire deleted the greg0ire:use-direct-group-for-phpunit-mode-deprecation branch May 30, 2019

@greg0ire greg0ire referenced this pull request May 30, 2019

Merged

Manual merge #409

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.