Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Inject RoutableMessageBus instead of bus locator #31748

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
5 participants
@chalasr
Copy link
Member

commented May 30, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31741
License MIT
Doc PR n/a

@chalasr chalasr added this to the 4.3 milestone May 30, 2019

@chalasr chalasr requested a review from sroze as a code owner May 30, 2019

@chalasr chalasr force-pushed the chalasr:inject-routable-messagebus branch 2 times, most recently from f8b2df9 to b0a4289 May 30, 2019

@chalasr

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Fabbot wants me to split new class { } into multiple lines so I'm going to ignore him :)

@chalasr chalasr force-pushed the chalasr:inject-routable-messagebus branch 2 times, most recently from 853449f to dc95fa5 May 30, 2019

@chalasr chalasr force-pushed the chalasr:inject-routable-messagebus branch 2 times, most recently from 53183c0 to 8b0342a May 30, 2019

@chalasr chalasr force-pushed the chalasr:inject-routable-messagebus branch from 8b0342a to 91817e4 May 31, 2019

@Tobion

Tobion approved these changes May 31, 2019

@fabpot

fabpot approved these changes May 31, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Thank you @chalasr.

@fabpot fabpot merged commit 91817e4 into symfony:4.3 May 31, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 31, 2019

bug #31748 [Messenger] Inject RoutableMessageBus instead of bus locat…
…or (chalasr)

This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Inject RoutableMessageBus instead of bus locator

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31741
| License       | MIT
| Doc PR        | n/a

Commits
-------

91817e4 [Messenger] Inject RoutableMessageBus instead of bus locator

@chalasr chalasr deleted the chalasr:inject-routable-messagebus branch May 31, 2019

fabpot added a commit that referenced this pull request Jun 1, 2019

feature #31785 [Messenger] Deprecate passing a bus locator to Consume…
…MessagesCommand's constructor (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand's constructor

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Continuation of #31748

Commits
-------

1409338 [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand constructor

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.