Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge][Validator] do not enable validator auto mapping by default #31749

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
6 participants
@xabbuh
Copy link
Member

commented May 30, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets part of #31715, #31752
License MIT
Doc PR
@phansys

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

I confirm this PR solves the issue reported at #31743.

@pamil

pamil approved these changes May 31, 2019

Copy link
Contributor

left a comment

Tested on Sylius, fixes the issue, thanks! 🎉

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit a3555fc into symfony:4.3 May 31, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 31, 2019

bug #31749 [DoctrineBridge][Validator] do not enable validator auto m…
…apping by default (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[DoctrineBridge][Validator] do not enable validator auto mapping by default

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #31715, #31752
| License       | MIT
| Doc PR        |

Commits
-------

a3555fc do not enable validator auto mapping by default

@xabbuh xabbuh deleted the xabbuh:issue-31715 branch May 31, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.