Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DomCrawler] Fix type error with null Form::$currentUri #31757

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
4 participants
@chalasr
Copy link
Member

commented May 30, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31644
License MIT
Doc PR n/a
@@ -44,7 +44,7 @@ class Form extends Link implements \ArrayAccess
*

This comment has been minimized.

Copy link
@chalasr

chalasr May 30, 2019

Author Member

I did not fix the docblock as there are plenty of missing |null across the component codebase, should be done globally on 3.4.

@chalasr chalasr referenced this pull request May 30, 2019

Closed

->form() throw exception #31644

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone May 31, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit e48d5d0 into symfony:4.2 May 31, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 31, 2019

bug #31757 [DomCrawler] Fix type error with null Form::$currentUri (c…
…halasr)

This PR was merged into the 4.2 branch.

Discussion
----------

[DomCrawler] Fix type error with null Form::$currentUri

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31644
| License       | MIT
| Doc PR        | n/a

Commits
-------

e48d5d0 [DomCrawler] Fix type error with null Form::$currentUri

@chalasr chalasr deleted the chalasr:domcrawler-form-null-uri branch May 31, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.