Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords #31763

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented May 31, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31758
License MIT
Doc PR -

Otherwise, the promise of the "auto" mode doesn't work.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 31, 2019

@chalasr

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Thank you @nicolas-grekas.

@chalasr chalasr merged commit c0fc456 into symfony:4.3 May 31, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

chalasr added a commit that referenced this pull request May 31, 2019

bug #31763 [Security\Core] Make SodiumPasswordEncoder validate BCrypt…
…-ed passwords (nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31758
| License       | MIT
| Doc PR        | -

Otherwise, the promise of the "auto" mode doesn't work.

Commits
-------

c0fc456 [Security\Core] Make SodiumPasswordEncoder validate BCrypt-ed passwords

@chalasr chalasr added the Security label May 31, 2019

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:sec-sodium-bcrypt branch May 31, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.