Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] don't add embedded properties to wrapping class metadata #31811

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
6 participants
@xabbuh
Copy link
Member

commented Jun 3, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31775
License MIT
Doc PR
@dunglas

dunglas approved these changes Jun 3, 2019

Copy link
Member

left a comment

Thanks for fixing this @xabbuh! You're too fast for me :)

@Korbeil

Korbeil approved these changes Jun 3, 2019

Copy link
Contributor

left a comment

Looks perfect, thanks ! 😃

@xabbuh xabbuh force-pushed the xabbuh:issue-31775 branch from 43a78cc to 56fe025 Jun 3, 2019

@xabbuh xabbuh changed the title [DoctrineBridge] don't wrapper embedded properties to wrapping class [DoctrineBridge] don't add embedded properties to wrapping class metadata Jun 3, 2019

@phansys

phansys approved these changes Jun 3, 2019

@fabpot

fabpot approved these changes Jun 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 56fe025 into symfony:4.3 Jun 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 4, 2019

bug #31811 [DoctrineBridge] don't add embedded properties to wrapping…
… class metadata (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[DoctrineBridge] don't add embedded properties to wrapping class metadata

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31775
| License       | MIT
| Doc PR        |

Commits
-------

56fe025 don't add embedded properties to wrapping class metadata

@xabbuh xabbuh deleted the xabbuh:issue-31775 branch Jun 4, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.