Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Fix profiler dump for non-invokable security listeners #31820

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
5 participants
@chalasr
Copy link
Member

commented Jun 3, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Listeners can be any callable since 4.3.

@chalasr chalasr added this to the 4.3 milestone Jun 3, 2019

@chalasr chalasr force-pushed the chalasr:dump-secu-listener branch from 078b441 to c462086 Jun 3, 2019

@nicolas-grekas nicolas-grekas force-pushed the chalasr:dump-secu-listener branch from c462086 to 250e252 Jul 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the chalasr:dump-secu-listener branch 2 times, most recently from acf2c31 to 0809daa Jul 8, 2019

@nicolas-grekas
Copy link
Member

left a comment

(I push-forced some tweaks)

@fabpot

fabpot approved these changes Jul 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the chalasr:dump-secu-listener branch from 0809daa to bc3d326 Jul 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the chalasr:dump-secu-listener branch from bc3d326 to f7738d9 Jul 8, 2019

@stof

stof approved these changes Jul 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @chalasr.

@fabpot fabpot merged commit f7738d9 into symfony:4.3 Jul 8, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

bug #31820 [SecurityBundle] Fix profiler dump for non-invokable secur…
…ity listeners (chalasr)

This PR was merged into the 4.3 branch.

Discussion
----------

[SecurityBundle] Fix profiler dump for non-invokable security listeners

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Listeners can be any callable since 4.3.

Commits
-------

f7738d9 [SecurityBundle] Fix profiler dump for non-invokable security listeners

@chalasr chalasr deleted the chalasr:dump-secu-listener branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.