Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code - catch \Throwable capture all exceptions #31822

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
4 participants
@lyrixx
Copy link
Member

commented Jun 3, 2019

Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT
Doc PR

This is a legacy when we did support PHP 5.X

Simplify code - catch \Throwable capture all exceptions
This is a legacy when we did support PHP 5.X

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Jun 3, 2019

@Tobion

Tobion approved these changes Jun 3, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit 648c694 into symfony:4.2 Jun 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 3, 2019

minor #31822 Simplify code - catch \Throwable capture all exceptions …
…(lyrixx)

This PR was merged into the 4.2 branch.

Discussion
----------

Simplify code - catch \Throwable capture all exceptions

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        |

---

This is a legacy when we did support PHP 5.X

Commits
-------

648c694 Simplify code - catch \Throwable capture all exceptions

@lyrixx lyrixx deleted the lyrixx:double-catch branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.