Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Remove BC layers and deprecated codes #31824

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
5 participants
@lyrixx
Copy link
Member

commented Jun 3, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

To do:

  • Component
  • Framework intergration

@lyrixx lyrixx force-pushed the lyrixx:workflow-deprec branch from 5ce6860 to e8f51ee Jun 4, 2019

@lyrixx lyrixx marked this pull request as ready for review Jun 4, 2019

@lyrixx lyrixx force-pushed the lyrixx:workflow-deprec branch from e8f51ee to cbb8b22 Jun 4, 2019

@fabpot

fabpot approved these changes Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit cbb8b22 into symfony:master Jun 5, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

minor #31824 [Workflow] Remove BC layers and deprecated codes (lyrixx)
This PR was squashed before being merged into the 5.0-dev branch (closes #31824).

Discussion
----------

[Workflow] Remove BC layers and deprecated codes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

To do:

* [x] Component
* [x] Framework intergration

Commits
-------

cbb8b22 [FrameworkBundle][Workflow] Remove BC layers and deprecated codes
08dc494 [Workflow] Remove BC layers and deprecated codes

@lyrixx lyrixx deleted the lyrixx:workflow-deprec branch Jun 5, 2019

fabpot added a commit that referenced this pull request Jun 7, 2019

minor #31924 [Workflow] Removed un-used dependency in composer.json (…
…lyrixx)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Workflow] Removed un-used dependency in composer.json

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

I forgot to remove this deps in #31824

Commits
-------

28f2dac [Workflow] Removed un-used dependency in composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.