Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] do not process private properties from parent class #31836

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

commented Jun 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31715, #31752
License MIT
Doc PR
@fabpot

fabpot approved these changes Jun 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit adfa1ef into symfony:4.3 Jun 4, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 4, 2019

bug #31836 [DoctrineBridge] do not process private properties from pa…
…rent class (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[DoctrineBridge] do not process private properties from parent class

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31715, #31752
| License       | MIT
| Doc PR        |

Commits
-------

adfa1ef do not process private properties from parent class

@xabbuh xabbuh deleted the xabbuh:issue-31715 branch Jun 4, 2019

@tristanbes

This comment has been minimized.

Copy link

commented Jun 5, 2019

Is there a way to temporarly fix the problem while staying in 4.3 without waiting a new release @xabbuh pleaase ? (eg: downgrade DoctrineBridge to another version ?)

EDIT: temporary fix is:

framework:
    validation:
        auto_mapping: {'App\\': {}} # Fix awaiting a new Symfony release (4.3.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.