Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Add check for Konsole/Yakuake to disable hyperlinks #31849

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@belinde
Copy link
Contributor

commented Jun 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31809
License MIT
Doc PR

Added check for environment variable set by Konsole and other relateds terminal emulators.

A ticket has been opened to Konsole team to support this feature someday: https://bugs.kde.org/show_bug.cgi?id=408288

@nicolas-grekas
Copy link
Member

left a comment

Could you please link to a Konsole issue so we can track when they fix this?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Oh, please also patch VarDumper, it has a similar check.

@belinde

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Oh, please also patch VarDumper, it has a similar check.

I'm on it. I've also noted that there was a test for TERMINAL_EMULATOR=JetBrains-JediTerm: should I add a test just for Konsole?

And what should I do, just add another commit to the PR or I must close it and do another one with the two commits squashed?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

No tests is OK to me, this wouldn't make much sense.

@belinde

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Opened bug report to Konsole: https://bugs.kde.org/show_bug.cgi?id=408288
Edited the description of the PR

@nicolas-grekas
Copy link
Member

left a comment

Thanks
For reference, this is a description of the feature for terminals:
https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda

And I just discovered this gist contains a link to an existing Konsole issue:
https://bugs.kde.org/show_bug.cgi?id=379294

(but your issue is different: it's about degrading gracefully - not necessarily about supporting links)

@fabpot

fabpot approved these changes Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @belinde.

@fabpot fabpot merged commit 14b27b7 into symfony:4.3 Jun 5, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #31849 [Console] Add check for Konsole/Yakuake to disable hyperli…
…nks (belinde)

This PR was squashed before being merged into the 4.3 branch (closes #31849).

Discussion
----------

[Console] Add check for Konsole/Yakuake to disable hyperlinks

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31809
| License       | MIT
| Doc PR        |

Added check for environment variable set by Konsole and other relateds terminal emulators.

A ticket has been opened to Konsole team to support this feature someday: https://bugs.kde.org/show_bug.cgi?id=408288

Commits
-------

14b27b7 [Console] Add check for Konsole/Yakuake to disable hyperlinks

@belinde belinde deleted the belinde:fix_Konsole branch Jun 5, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.