Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] add missing symfony/service-contracts dependency #31852

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jun 4, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31844
License MIT
Doc PR -

ResetInterface is needed by CachingFactoryDecorator, which is used in CoreExtension, so this is a mandatory dep.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 4, 2019

@nicolas-grekas nicolas-grekas requested a review from xabbuh as a code owner Jun 4, 2019

@stof

stof approved these changes Jun 4, 2019

@fabpot

fabpot approved these changes Jun 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 8639bcc into symfony:4.3 Jun 4, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 4, 2019

bug #31852 [Form] add missing symfony/service-contracts dependency (n…
…icolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[Form] add missing symfony/service-contracts dependency

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31844
| License       | MIT
| Doc PR        | -

`ResetInterface` is needed by `CachingFactoryDecorator`, which is used in `CoreExtension`, so this is a mandatory dep.

Commits
-------

8639bcc [Form] add missing symfony/service-contracts dependency

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-form-dep branch Jun 5, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.