Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the Symfony Mailer service implementation to avoid conflict with SwitMailer #31854

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
5 participants
@tgalopin
Copy link
Member

commented Jun 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

When you install Symfony Mailer as well as SwitMailer and try to typehint MailerInterface, the autowiring alias is aliased to the "mailer" service which is overriden by SwitMailer, thus making the injection fail.

@tgalopin tgalopin changed the base branch from 4.4 to 4.3 Jun 4, 2019

@tgalopin tgalopin changed the title Rename the Symfony Mailer service implementation to avoid conflict wi… Rename the Symfony Mailer service implementation to avoid conflict with SwitMailer Jun 4, 2019

@tgalopin tgalopin force-pushed the tgalopin:patch-2 branch from d9ff0ce to 5fa9d63 Jun 4, 2019

@tgalopin tgalopin force-pushed the tgalopin:patch-2 branch from 5fa9d63 to e7c96d3 Jun 4, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 4, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

I hit this too :)

composer create-project symfony/website-skeleton sf43w
cd sf43w
composer require symfony/mailer
bin/console make:command tito
# type-hint the new MailerInterface => BOOM
@fabpot

fabpot approved these changes Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @tgalopin.

@fabpot fabpot merged commit e7c96d3 into symfony:4.3 Jun 5, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #31854 Rename the Symfony Mailer service implementation to avoid …
…conflict with SwitMailer (tgalopin)

This PR was merged into the 4.3 branch.

Discussion
----------

Rename the Symfony Mailer service implementation to avoid conflict with SwitMailer

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

When you install Symfony Mailer as well as SwitMailer and try to typehint MailerInterface, the autowiring alias is aliased to the "mailer" service which is overriden by SwitMailer, thus making the injection fail.

Commits
-------

e7c96d3 Rename the Symfony Mailer service config to avoid conflict with SwitMailer

@tgalopin tgalopin deleted the tgalopin:patch-2 branch Jun 5, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

@cybernet

This comment has been minimized.

Copy link

commented Jun 11, 2019

switmailer typo in the title, also in 4.3.1 changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.