Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] work around PHP 7.3 bug related to json_encode() #31861

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jun 4, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This is the remaining of ##31860 for upper branches.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 4, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-json-73 branch from 8a9ef96 to 42904e3 Jun 4, 2019

@LordNouda
Copy link

left a comment

Hi Nicolas,

I checked this according to @weaverryan 's great tutorial on contributing back to Symfony over at SymfonyCasts. I could reproduce the error with PHP@7.3.6. With PHP@7.2.19 it does not occur.

I hope this helps.

I'm relatively new to Symfony and this would be my first contribution.

Cheers, Manuel

@fabpot

fabpot approved these changes Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 42904e3 into symfony:4.3 Jun 5, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #31861 [HttpClient] work around PHP 7.3 bug related to json_encod…
…e() (nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] work around PHP 7.3 bug related to json_encode()

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is the remaining of ##31860 for upper branches.

Commits
-------

42904e3 [HttpClient] work around PHP 7.3 bug related to json_encode()

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #31871 [HttpClient] revert bad logic around JSON_THROW_ON_ERROR (…
…nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] revert bad logic around JSON_THROW_ON_ERROR

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Same as #31869, reverts #31861

Commits
-------

846116e [HttpClient] revert bad logic around JSON_THROW_ON_ERROR

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-json-73 branch Jun 5, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.