Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor #31863

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@mrbaileys
Copy link

commented Jun 5, 2019

…r in RedirectResponse constructor.

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31862
License MIT

Perform a case-insensitive check on $headers in \Symfony\Component\HttpFoundation\RedirectResponse::__construct()

Ivo
@mrbaileys

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

Test is succeeds when in run it locally, so not sure why it is failing here.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 5, 2019

@nicolas-grekas nicolas-grekas changed the title [HttpFoundation] Fixed case-sensitive handling of cache-control heade… [HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor Jun 5, 2019

@fabpot

fabpot approved these changes Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @mrbaileys.

@fabpot fabpot merged commit b5e6c99 into symfony:3.4 Jun 5, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #31863 [HttpFoundation] Fixed case-sensitive handling of cache-co…
…ntrol header in RedirectResponse constructor (Ivo)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor

…r in RedirectResponse constructor.

| Q             | A
| ------------- | ---
| Branch?       |  3.4
| Bug fix?      | yes
| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31862  <!-- #-prefixed issue number(s), if any -->
| License       | MIT

Perform a case-insensitive check on `$headers` in \Symfony\Component\HttpFoundation\RedirectResponse::__construct()

Commits
-------

b5e6c99 [HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor.

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.