[DIC] Add a split env var processor

[Orkin]

Q	A
Branch?	4.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR	symfony/symfony-docs#11674

This adds a new explode processor that will explode a string to a PHP array

[nicolas-grekas]

I think you should use the csv processor instead.

[OskarStark]

This feature should go in 4.4 branch instead of master, same for the corresponding docs PR please 🙏

[ro0NL]

Agree with @nicolas-grekas , you can already use the csv processor: https://3v4l.org/iGdpS

[Orkin]

@OskarStark base branch updated ;)

[OskarStark]

@Orkin can you please give us some more insights, why you cannot/wont use the csv processor?

Thank you

[ro0NL]

i realized there can be different behavior :) https://3v4l.org/gOCPR

that's escaping support out-of-the box 😅 but perhaps that works counter-wise for @Orkin

for the csv processor itself, from the example above; im not sure why PHP doesnt unescape d\",\"e

So for the default parameter values "" and \" have the same meaning. (https://php.net/str_getcsv)

Perhaps SF should fix it?

[nicolas-grekas]

@ro0NL same as in #32007? Worth a PR on the csv process? Please submit a PR if you think so.
But anyway, we're missing feedback from @Orkin before we can make guesses.

[ro0NL]

not sure if #32007 is related, as it fixes the encoding of bool(true) into "1". AFAIK Serializer doesnt decode "1" back into bool(true). Nor does PHP: https://3v4l.org/YckLo

For DI it's bool:key:N:csv:ENV IMHO.

If we decide to unescape the escape char, both DI + Serializer should do that yes. (Unless the escape char is ": https://3v4l.org/lgrDY)

https://bugs.php.net/bug.php?id=55413 is the bug report.

[Orkin]

Hi, @OskarStark @nicolas-grekas first of all because I didn't know the csv processor. For my usecase it's for memcached server list retrieve via environment variable so for my need it's easier to split by something.
I choose a comma , but perhaps in the future it can be a space or a pipe |. It can be usefull to separate csv processor to a real flat array string and to get the availability to specify the separator.

I don't know as much env var processor so I don't have any ideas if it's possible and if not what kind of format it can be used. But in the future it can be a improvement.

And last thing, I don't want my string to be escaped because it can be url or something that need to stay in the same format

[OskarStark]

In this case it makes sense to me to not use the csv processor and got with the new explode one. Also from a DX perspective, having csv:MEMCACHED_HOSTS... looks weird

[ro0NL]

Id prefer split then 👍

[OskarStark]

Sounds good to me, but I think it’s more common to use explode kn the php context, also because of split is an old PHP 5.3 deprecated method

https://www.php.net/manual/en/function.split.php

But definitely better then using csv here 👍🏻

[ro0NL]

that's the thing, explode sounds PHP specific whereas in SF DI config it should be more language agnostic IMHO. Agree csv might look weird.

split by something. I choose a comma , but perhaps in the future it can be a space or a pipe |

i think having both split:ENV as well as split:|:CSV seems sensible 👍

[Orkin]

It didn’t know and find the csv processor because it seems to me weird for my use case.
I’m agree with split because it’s a more common word but we are in a PHP world so most of the users of SF are PHP developers and when a PHP developer want to transform a string into an array the first function in his mind is explode that’s why it seems better to me.
We can imagine someone typing something like that in google how to explose an array in symfony yaml config

[ro0NL]

maybe csv is weird because of #25627 (comment), currently it accepts a single row, so it's somewhat split_escaped:ENV actually

i tend to believe people associate "CSV" with a collection of rows

explode vs. split: the latter is shorter.

[OskarStark]

Let’s go with split then

[Orkin]

Everything is up to date ;)

[OskarStark]

Please update the PR title

[fabpot]

Not sure we need yet another processor. csv works for most cases (even if not easily discoverable), and json works for more complex cases.

Here, I'm sure some will want to have another separator than ,, and others will want to be able to escape the separator.

So, I'm 👎 for this addition.

[nicolas-grekas]

Closing as explained, thanks for proposing.