Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Fix handling non-catchable fatal errors #31868

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jun 5, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This reverts PR #27519 this commit 18c2dde,
reversing changes made to ac1189a.

Right now, the listener is skipped on fatal errors.

[HttpKernel] Fix handling non-catchable fatal errors
This reverts PR #27519 this commit 18c2dde,
reversing changes made to ac1189a.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:debug-http-exceptions branch from 97e2f07 to a1619cc Jun 5, 2019

@fabpot

fabpot approved these changes Jun 5, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit a1619cc into symfony:4.2 Jun 5, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 5, 2019

bug #31868 [HttpKernel] Fix handling non-catchable fatal errors (nico…
…las-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[HttpKernel] Fix handling non-catchable fatal errors

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This reverts PR #27519 this commit 18c2dde,
reversing changes made to ac1189a.

Right now, the listener is skipped on fatal errors.

Commits
-------

a1619cc [HttpKernel] Fix handling non-catchable fatal errors

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:debug-http-exceptions branch Jun 5, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.