Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doctrine Bridge] Check field type before adding Length constraint #31874

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
4 participants
@belinde
Copy link
Contributor

commented Jun 5, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31855
License MIT
Doc PR

Validator\DoctrineLoader now add a Length constraint only on field of type string, text and guid; for any other type the mapping length is just ignored

@belinde belinde marked this pull request as ready for review Jun 5, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 5, 2019

@belinde belinde changed the title Check field type before adding Length constraint [Doctrine Bridge] Check field type before adding Length constraint Jun 5, 2019

@xabbuh xabbuh force-pushed the belinde:issue31855 branch from 4eb5964 to 35e6df6 Jun 6, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Thank you @belinde.

@xabbuh xabbuh merged commit 35e6df6 into symfony:4.3 Jun 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

xabbuh added a commit that referenced this pull request Jun 6, 2019

bug #31874 [Doctrine Bridge] Check field type before adding Length co…
…nstraint (belinde)

This PR was squashed before being merged into the 4.3 branch (closes #31874).

Discussion
----------

[Doctrine Bridge] Check field type before adding Length constraint

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31855
| License       | MIT
| Doc PR        |

Validator\DoctrineLoader now add a Length constraint only on field of type string, text and guid; for any other type the mapping length is just ignored

Commits
-------

35e6df6 [Doctrine Bridge] Check field type before adding Length constraint

@belinde belinde deleted the belinde:issue31855 branch Jun 6, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.