Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] remove deprecated code paths #31898

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Jun 6, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 6, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-validator branch from 90bfa80 to 4179ce4 Jun 6, 2019

@nicolas-grekas nicolas-grekas marked this pull request as ready for review Jun 6, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-validator branch 3 times, most recently from d8402bc to e9eb707 Jun 6, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-validator branch from e9eb707 to 7bb0359 Jun 6, 2019

* @author Bernhard Schussek <bschussek@gmail.com>
*
* @final since Symfony 4.2

This comment has been minimized.

Copy link
@nicolas-grekas

@nicolas-grekas nicolas-grekas merged commit 7bb0359 into symfony:master Jun 6, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 6, 2019

minor #31898 [Validator] remove deprecated code paths (nicolas-grekas)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Validator] remove deprecated code paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7bb0359 [Validator] remove deprecated code paths

nicolas-grekas added a commit that referenced this pull request Jun 6, 2019

minor #31899 [FrameworkBundle] remove deprecated code paths (nicolas-…
…grekas)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[FrameworkBundle] remove deprecated code paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Needs #31898

Commits
-------

30418cf [FrameworkBundle] remove deprecated code paths

nicolas-grekas added a commit that referenced this pull request Jun 6, 2019

bug #31908 [Validator] fix deprecation layer of ValidatorBuilder (nic…
…olas-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[Validator] fix deprecation layer of ValidatorBuilder

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As identified in #31898: we cannot remove the interface and make the replacing implementation final in the same run. This PR turns only setTranslator() final to allow changing its type hint in 5.0.

Commits
-------

154ce81 [Validator] fix deprecation layer of ValidatorBuilder

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:5-validator branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.