Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] fix deprecation layer of ValidatorBuilder #31908

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Jun 6, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

As identified in #31898: we cannot remove the interface and make the replacing implementation final in the same run. This PR turns only setTranslator() final to allow changing its type hint in 5.0.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:valid-deprec branch from 09ae62c to 154ce81 Jun 6, 2019

@nicolas-grekas nicolas-grekas merged commit 154ce81 into symfony:4.2 Jun 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 6, 2019

bug #31908 [Validator] fix deprecation layer of ValidatorBuilder (nic…
…olas-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[Validator] fix deprecation layer of ValidatorBuilder

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As identified in #31898: we cannot remove the interface and make the replacing implementation final in the same run. This PR turns only setTranslator() final to allow changing its type hint in 5.0.

Commits
-------

154ce81 [Validator] fix deprecation layer of ValidatorBuilder

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:valid-deprec branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.