Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] remove all deprecated event and replace their use #31918

Conversation

Projects
None yet
3 participants
@Simperfit
Copy link
Contributor

commented Jun 7, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR to check

Extract the whole event & listener part from #31672 (comment) to its own PR to ease the removal of deprecated code from HttpKernel.

@Simperfit Simperfit force-pushed the Simperfit:deprecate/remove-the-deprecated-events branch from fef785c to 8dea389 Jun 7, 2019

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 7, 2019

@Simperfit Simperfit force-pushed the Simperfit:deprecate/remove-the-deprecated-events branch 2 times, most recently from 51b9320 to d7099c5 Jun 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Needs #31938

nicolas-grekas added a commit that referenced this pull request Jun 7, 2019

minor #31938 [FrameworkBundle] fix FC with HttpKernel v5 (nicolas-gre…
…kas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix FC with HttpKernel v5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This class is deprecated and is thus not enough a reason to conflict with http-kernel v5

Should unlock #31918

Commits
-------

6c109c7 [FrameworkBundle] fix FC with HttpKernel v5

@Simperfit Simperfit force-pushed the Simperfit:deprecate/remove-the-deprecated-events branch from d7099c5 to 48073dd Jun 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit be5f641 into symfony:master Jun 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 8, 2019

minor #31918 [HttpKernel] remove all deprecated event and replace the…
…ir use (Simperfit, nicolas-grekas)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[HttpKernel] remove all deprecated event and replace their use

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |to check<!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Extract the whole event & listener part from  #31672 (comment) to its own PR to ease the removal of deprecated code from HttpKernel.

Commits
-------

be5f641 Fix annotations
48073dd [HttpKernel] remove all deprecated event and replace their use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.