Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Removed un-used dependency in composer.json #31924

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
5 participants
@lyrixx
Copy link
Member

commented Jun 7, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

I forgot to remove this deps in #31824

@xavismeh

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

You could also remove (Single|Multiple)StateMarkingStore classes, couldn't you?

@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

You could also remove (Single|Multiple)StateMarkingStore classes, couldn't you?

They does not exist anymore. See #31824

@stof

stof approved these changes Jun 7, 2019

@fabpot

fabpot approved these changes Jun 7, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 28f2dac into symfony:master Jun 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 7, 2019

minor #31924 [Workflow] Removed un-used dependency in composer.json (…
…lyrixx)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Workflow] Removed un-used dependency in composer.json

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

I forgot to remove this deps in #31824

Commits
-------

28f2dac [Workflow] Removed un-used dependency in composer.json

@lyrixx lyrixx deleted the lyrixx:workflow-deprec branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.