Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] avoid service id conflicts with Swiftmailer #31928

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

commented Jun 7, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31906
License MIT
Doc PR
@@ -1916,7 +1916,7 @@ private function registerMailerConfiguration(array $config, ContainerBuilder $co
}
$loader->load('mailer.xml');
$container->getDefinition('mailer.transport')->setArgument(0, $config['dsn']);
$container->getDefinition('mailer.default_transport')->setArgument(0, $config['dsn']);

This comment has been minimized.

Copy link
@xabbuh
@fabpot

fabpot approved these changes Jun 7, 2019

@xabbuh

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

alternatively, we can update the compiler pass in MonologBundle and check the transport class there

<argument type="service" id="messenger.default_bus" on-invalid="ignore" />
</service>
<service id="mailer" alias="mailer.mailer" />
<service id="Symfony\Component\Mailer\MailerInterface" alias="mailer.mailer" />

<service id="mailer.transport" class="Symfony\Component\Mailer\Transport\TransportInterface">
<service id="mailer.default_transport" class="Symfony\Component\Mailer\Transport\TransportInterface">

This comment has been minimized.

Copy link
@xabbuh

xabbuh Jun 7, 2019

Author Member

changing the id here might cause trouble for developers who have already updated and are using this id

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 5ce0ede into symfony:4.3 Jun 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 7, 2019

bug #31928 [FrameworkBundle] avoid service id conflicts with Swiftmai…
…ler (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] avoid service id conflicts with Swiftmailer

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31906
| License       | MIT
| Doc PR        |

Commits
-------

5ce0ede avoid service id conflicts with Swiftmailer

@xabbuh xabbuh deleted the xabbuh:issue-31906 branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.