Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] fix FC with HttpKernel v5 #31938

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jun 7, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This class is deprecated and is thus not enough a reason to conflict with http-kernel v5

Should unlock #31918

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fwb-fc branch from c517349 to 6c109c7 Jun 7, 2019

@Simperfit
Copy link
Contributor

left a comment

Travis failure is not related

@nicolas-grekas nicolas-grekas merged commit 6c109c7 into symfony:4.4 Jun 7, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 7, 2019

minor #31938 [FrameworkBundle] fix FC with HttpKernel v5 (nicolas-gre…
…kas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix FC with HttpKernel v5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This class is deprecated and is thus not enough a reason to conflict with http-kernel v5

Should unlock #31918

Commits
-------

6c109c7 [FrameworkBundle] fix FC with HttpKernel v5

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fwb-fc branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.