Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix suspicious test #31944

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
4 participants
@ro0NL
Copy link
Contributor

commented Jun 7, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31942
License MIT
Doc PR symfony/symfony-docs#...

cc @nicolas-grekas

@ro0NL ro0NL changed the base branch from 4.4 to 4.2 Jun 7, 2019

@Simperfit
Copy link
Contributor

left a comment

Thanks !

@nicolas-grekas nicolas-grekas force-pushed the ro0NL:di-tests branch from 2a26f0a to 25b961a Jun 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit 25b961a into symfony:4.2 Jun 8, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 8, 2019

minor #31944 [DI] Fix suspicious test (ro0NL)
This PR was merged into the 4.2 branch.

Discussion
----------

[DI] Fix suspicious test

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31942
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

cc @nicolas-grekas

Commits
-------

25b961a [DI] Fix suspicious test

nicolas-grekas added a commit that referenced this pull request Jun 8, 2019

minor #31945 [DI][5.0] Fix suspicious test (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI][5.0] Fix suspicious test

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Cleanup of #31944 for 5.0

Commits
-------

98c25dd [DI][5.0] Fix suspicious test

@ro0NL ro0NL deleted the ro0NL:di-tests branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.