Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI][5.0] Fix suspicious test #31945

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
3 participants
@ro0NL
Copy link
Contributor

commented Jun 7, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Cleanup of #31944 for 5.0

/**
* @group legacy
*/
public function testConfigurationWithoutRootNode(): void

This comment has been minimized.

Copy link
@ro0NL

ro0NL Jun 7, 2019

Author Contributor

this cannot happen anymore with Config 5.0, in the #31678 the deps are updated .. as such i assumed we dont need this test anymore.

/**
* @author Roland Franssen <franssen.roland@gmail.com>
*/
class TreeWithoutRootNodeException extends \RuntimeException

This comment has been minimized.

Copy link
@ro0NL

ro0NL Jun 7, 2019

Author Contributor

maybe we forgot to mark this @internal in 4.x ... 😅

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 8, 2019

Member

let's add it #31944 :)

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit 98c25dd into symfony:master Jun 8, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 8, 2019

minor #31945 [DI][5.0] Fix suspicious test (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI][5.0] Fix suspicious test

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Cleanup of #31944 for 5.0

Commits
-------

98c25dd [DI][5.0] Fix suspicious test

@ro0NL ro0NL deleted the ro0NL:di-tests-50 branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.