Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] remove deprecated code paths #31951

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jun 8, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@ro0NL there is still one legacy test in ValidateEnvPlaceholdersPassTest, I'll let you remove it if you don't mind, please :)

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-di branch from 616e4d5 to d0abf10 Jun 8, 2019

@ro0NL

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

you mean the one from #31678?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

Oh, sure! :)

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-di branch from d0abf10 to 3ff69f0 Jun 8, 2019

@nicolas-grekas nicolas-grekas merged commit 3ff69f0 into symfony:master Jun 8, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 8, 2019

minor #31951 [DI] remove deprecated code paths (nicolas-grekas)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] remove deprecated code paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

@ro0NL there is still one legacy test in ValidateEnvPlaceholdersPassTest, I'll let you remove it if you don't mind, please :)

Commits
-------

3ff69f0 [DI] remove deprecated code paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.