Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpunitBridge] Restore memoization #31955

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@greg0ire
Copy link
Contributor

commented Jun 8, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

I must have inadvertently dropped it in 1c73f9c

@greg0ire greg0ire changed the title Restore memoization [PhpunitBridge] Restore memoization Jun 8, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 8, 2019

@greg0ire greg0ire force-pushed the greg0ire:restore-memoization branch from 23e13eb to 8ff10a4 Jun 8, 2019

@greg0ire

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Looks like I broke something 😕

EDIT: should be fine now.

Remove useless memoization remnant
I should have removed it in 1c73f9c

@greg0ire greg0ire force-pushed the greg0ire:restore-memoization branch from 8ff10a4 to 3b0e9df Jun 8, 2019

@@ -215,9 +214,7 @@ private function getConfiguration()
if (null !== $this->configuration) {
return $this->configuration;
}
if (false === $mode = $this->mode) {

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 9, 2019

Member

Not sure this is legit: the property is used L88.

This comment has been minimized.

Copy link
@greg0ire

greg0ire Jun 9, 2019

Author Contributor

Oh, you're right, good catch! Closing then.

@greg0ire greg0ire closed this Jun 9, 2019

@greg0ire greg0ire deleted the greg0ire:restore-memoization branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.