Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code paths that trigger a runtime notice #31957

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jun 8, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-gen-cleanu branch 3 times, most recently from 8e0b4f3 to 5a1dc1e Jun 8, 2019

@nicolas-grekas nicolas-grekas marked this pull request as ready for review Jun 9, 2019

@nicolas-grekas nicolas-grekas requested a review from dunglas as a code owner Jun 9, 2019

@@ -48,7 +48,7 @@ public function onAuthentication(Request $request, TokenInterface $token)
case self::MIGRATE:
// Note: this logic is duplicated in several authentication listeners
// until Symfony 5.0 due to a security fix with BC compat
// until Symfony 5.0 due to a security fix with BC compat XXX

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 9, 2019

Author Member

What does this mean for 5.0 @weaverryan? What should be done now?

This comment has been minimized.

Copy link
@Simperfit

Simperfit Jun 9, 2019

Contributor

removing the duplicated logic in other listener I think

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 9, 2019

Author Member

this is the only remaining part that I didn't update in this PR
@weaverryan maybe, up for a PR?

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-gen-cleanu branch from 5a1dc1e to 133325a Jun 9, 2019

@nicolas-grekas nicolas-grekas requested review from lyrixx and sroze as code owners Jun 9, 2019

@lyrixx

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

👍 for the workflow part

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-gen-cleanu branch from 133325a to 818444c Jun 9, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:5-gen-cleanu branch from 818444c to 3962248 Jun 9, 2019

@nicolas-grekas nicolas-grekas merged commit 3962248 into symfony:master Jun 9, 2019

1 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

nicolas-grekas added a commit that referenced this pull request Jun 9, 2019

minor #31957 Remove deprecated code paths that trigger a runtime noti…
…ce (nicolas-grekas)

This PR was merged into the 5.0-dev branch.

Discussion
----------

Remove deprecated code paths that trigger a runtime notice

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

3962248 Remove deprecated code paths that trigger a runtime notice

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:5-gen-cleanu branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.