Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] add a deprecation for global dir #31958

Open
wants to merge 1 commit into
base: 4.4
from

Conversation

Projects
None yet
4 participants
@Simperfit
Copy link
Contributor

commented Jun 8, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #31915
License MIT
Doc PR none

@Tobion is this what you had in mind ?

@Simperfit Simperfit force-pushed the Simperfit:deprecated/add-deprecation-for-global-dir branch from b6a8551 to 78bd10a Jun 8, 2019

@Simperfit Simperfit force-pushed the Simperfit:deprecated/add-deprecation-for-global-dir branch from 78bd10a to 1d9cd50 Jun 8, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 9, 2019

@Simperfit Simperfit force-pushed the Simperfit:deprecated/add-deprecation-for-global-dir branch 3 times, most recently from 97424f6 to 5ee876a Jun 12, 2019

@Simperfit Simperfit force-pushed the Simperfit:deprecated/add-deprecation-for-global-dir branch from 5ee876a to fe45176 Jun 14, 2019

@Simperfit

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

@Tobion @nicolas-grekas I've changed things a little bit, prepared the removels of the constructor argument like said and move the deprecation where it actually loads the file testing if it's load it globally or not, hope that's what you had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.