Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] test case is not legacy #31963

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jun 9, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

At least it's green.
/cc @xabbuh @HeahDude

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 9, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

I think this was mistakenly added when the test was introduced in #17163.

@xabbuh

xabbuh approved these changes Jun 11, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thank you @nicolas-grekas.

@xabbuh xabbuh merged commit 9ad324b into symfony:3.4 Jun 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

xabbuh added a commit that referenced this pull request Jun 11, 2019

minor #31963 [Form] test case is not legacy (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] test case is not legacy

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

At least it's green.
/cc @xabbuh @HeahDude

Commits
-------

9ad324b [Form] test case is not legacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.