Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add callback to BinaryFileResponse #31974

Open
wants to merge 2 commits into
base: 4.4
from

Conversation

Projects
None yet
5 participants
@ricventu
Copy link

commented Jun 10, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Added a callback to BinaryFileResponse, called after send of the content

@derrabus
Copy link
Contributor

left a comment

This PR contains commits from the master branch. Please rebase against 4.4.

@ricventu ricventu force-pushed the ricventu:bfr_cb branch from 6b05eff to d963e43 Jun 13, 2019

@ricventu

This comment has been minimized.

Copy link
Author

commented Jun 13, 2019

rebased against 4.4

@lyrixx

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Hello,

Thanks for your first contribution.

What is your use case?

@ricventu

This comment has been minimized.

Copy link
Author

commented Jun 13, 2019

Hello,
after send the content of file I need to do some stuff instead of delete it, without the support of queue jobs or something else

@lyrixx

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Why don't you register a listener on kernel.terminate ?

@ricventu

This comment has been minimized.

Copy link
Author

commented Jun 16, 2019

I will try it. Thanks for your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.