Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventDispatcher] collect called listeners information only once #31991

Closed
wants to merge 1 commit into from

Conversation

@xabbuh
Copy link
Member

commented Jun 11, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31970
License MIT
Doc PR

@xabbuh xabbuh added the Performance label Jun 11, 2019

@xabbuh xabbuh added this to the next milestone Jun 11, 2019

@xabbuh xabbuh force-pushed the xabbuh:issue-31970 branch from e2da46f to bb963ed Jun 11, 2019

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@derrabus

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Can't we target 4.2 with this change?

@Simperfit

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

if this has been introduced in 4.2 I think this should target 4.2 as this is more than a bugfix !

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

In the past, our policy with performance improvements was:

  • Never merge them in older branches. It's tempting to do ... but at the same time, it's too easy to introduce bugs.
  • Only merging in "next" branch is great to promote the performance improvements of the new version (and encourage upgrading).

Things can change though if this is considered a bug fix.

@fabpot

fabpot approved these changes Jun 11, 2019

@nicolas-grekas
Copy link
Member

left a comment

(I'd be fine with 4.2 :) )

@lyrixx

lyrixx approved these changes Jun 11, 2019

Copy link
Member

left a comment

👍 for 4.2 too

@fabpot fabpot changed the base branch from 4.4 to 4.3 Jun 11, 2019

@fabpot fabpot force-pushed the xabbuh:issue-31970 branch from bb963ed to fb59f8c Jun 11, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Jun 11, 2019

bug #31991 [EventDispatcher] collect called listeners information onl…
…y once (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[EventDispatcher] collect called listeners information only once

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31970
| License       | MIT
| Doc PR        |

Commits
-------

284262a collect called listeners information only once

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Jun 11, 2019

@fabpot fabpot closed this Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.