Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize Mailgun's region #31998

Merged
merged 1 commit into from Jun 14, 2019

Conversation

Projects
None yet
6 participants
@jderusse
Copy link
Contributor

commented Jun 11, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #31810
License MIT
Doc PR TODO

Mailgun is available in 2 regions (US and EU), when registering a custom domain, users can choose one of the 2 regions and have to use the right the endpoint (see documentation https://documentation.mailgun.com/en/latest/api-intro.html?highlight=smtp.mailgun.org#mailgun-regions).

This PR make the endpoint/region configurable.

@Koc

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

possible duplicate of #31897
relates to #31810

@jderusse

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

my bad. Implemented the code last week and didn't noticed someone opened another PR

@jderusse jderusse closed this Jun 11, 2019

@jderusse

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

looking at #31897, I think that the approach of this PR is way simpler. Reopening it

@jderusse jderusse reopened this Jun 11, 2019

@jderusse jderusse force-pushed the jderusse:fix-mailgun-host branch 3 times, most recently from bdd7b45 to 35aac7f Jun 11, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 12, 2019

@jderusse jderusse force-pushed the jderusse:fix-mailgun-host branch 2 times, most recently from 762ab8c to 85cd694 Jun 12, 2019

@jderusse jderusse force-pushed the jderusse:fix-mailgun-host branch from 85cd694 to 7439c8d Jun 13, 2019

@jderusse jderusse changed the base branch from 4.4 to 4.3 Jun 13, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Jun 13, 2019

@nicolas-grekas nicolas-grekas added Bug and removed Feature labels Jun 13, 2019

@fabpot

fabpot approved these changes Jun 14, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Thank you @jderusse.

@fabpot fabpot merged commit 7439c8d into symfony:4.3 Jun 14, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 14, 2019

bug #31998 Parameterize Mailgun's region (jderusse)
This PR was merged into the 4.3 branch.

Discussion
----------

Parameterize Mailgun's region

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31810
| License       | MIT
| Doc PR        | TODO

Mailgun is available in 2 regions (US and EU), when registering a custom domain, users can choose one of the 2 regions and **have to** use the right the endpoint (see documentation https://documentation.mailgun.com/en/latest/api-intro.html?highlight=smtp.mailgun.org#mailgun-regions).

This PR make the endpoint/region configurable.

Commits
-------

7439c8d Parameterize Mailgun's region
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.