Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] fix closing debug stream prematurely #32011

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Jun 12, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31985
License MIT
Doc PR -

@ElGecko76 can you please confirm this fixes the issue for you?
I'm not able to reproduce so I can't myself. Thanks.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jun 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-debug branch from 21857a1 to 380de9b Jun 12, 2019

@nicolas-grekas nicolas-grekas changed the title [HttpClient] fix closing debug stream prematurely [HttpClient] ensure debug stream is closed properly Jun 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-debug branch from 380de9b to 61c2851 Jun 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-debug branch from 61c2851 to 265c1b9 Jun 12, 2019

@nicolas-grekas nicolas-grekas changed the title [HttpClient] ensure debug stream is closed properly [HttpClient] fix closing debug stream prematurely Jun 12, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-debug branch from 265c1b9 to 21857a1 Jun 12, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

I managed to reproduce the issue and I confirm the attached patch works.

@fabpot

fabpot approved these changes Jun 13, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 21857a1 into symfony:4.3 Jun 13, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 13, 2019

bug #32011 [HttpClient] fix closing debug stream prematurely (nicolas…
…-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] fix closing debug stream prematurely

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31985
| License       | MIT
| Doc PR        | -

@ElGecko76 can you please confirm this fixes the issue for you?
I'm not able to reproduce so I can't myself. Thanks.

Commits
-------

21857a1 [HttpClient] fix closing debug stream prematurely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.