Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Add a way to anonymize IPs #32194

Merged
merged 1 commit into from Nov 9, 2019

Conversation

@Seldaek
Copy link
Member

Seldaek commented Jun 26, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#... TODO

This is helpful for GDPR compliance reasons, and it isn't much code saved but it's also good if you don't have to think about how to do it.

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 26, 2019
@Seldaek Seldaek force-pushed the Seldaek:anonymize_ips branch from 3cee079 to e2dc6c1 Nov 8, 2019
@Seldaek

This comment has been minimized.

Copy link
Member Author

Seldaek commented Nov 8, 2019

Ok I updated wording/docblock, added tests and support for IPv4-mapped IPv6s (which complicates things a little, if anyone sees a better way to do this feel free, as long as the tests pass..), and now remove the last 8 bytes (/64 equivalent) of IPv6s.

For me it's ready to ship now but any feedback is appreciated.

@Seldaek Seldaek force-pushed the Seldaek:anonymize_ips branch from e2dc6c1 to 9e62330 Nov 8, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Nov 8, 2019
@chalasr
chalasr approved these changes Nov 8, 2019
@fabpot
fabpot approved these changes Nov 9, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Nov 9, 2019

Thank you @Seldaek.

fabpot added a commit that referenced this pull request Nov 9, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] Add a way to anonymize IPs

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features --> TODO

This is helpful for GDPR compliance reasons, and it isn't much code saved but it's also good if you don't have to think about how to do it.

Commits
-------

9e62330 [HttpFoundation] Add a way to anonymize IPs
@fabpot fabpot merged commit 9e62330 into symfony:4.4 Nov 9, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.