Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] deprecate the framework.templating option #32267

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@xabbuh
Copy link
Member

commented Jun 28, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #32120
License MIT
Doc PR

The config node has already been removed in the master branch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix.

@xabbuh xabbuh added this to the next milestone Jun 28, 2019

@xabbuh xabbuh force-pushed the xabbuh:issue-32120 branch from 14f8b34 to 8099213 Jun 28, 2019

@Tobion

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

This should go in 4.3 because that's where the deprecation happened. You cannot fix the other deprecations without removing the config. So this is a requirement and serves as explanation.

@Tobion

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Please also add the instructions to UPGRADE-4.3.md as pointed out in #32120

@xabbuh xabbuh force-pushed the xabbuh:issue-32120 branch from 8099213 to b7a6879 Jun 29, 2019

@xabbuh xabbuh changed the base branch from 4.4 to 4.3 Jun 29, 2019

@xabbuh xabbuh modified the milestones: next, 4.3 Jun 29, 2019

@xabbuh

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

This should go in 4.3 because that's where the deprecation happened. You cannot fix the other deprecations without removing the config. So this is a requirement and serves as explanation.

You are right. I have just checked this on a fresh installation.

@xabbuh xabbuh force-pushed the xabbuh:issue-32120 branch from b7a6879 to ba241ce Jun 29, 2019

@Tobion

Tobion approved these changes Jun 29, 2019

@chalasr

chalasr approved these changes Jul 2, 2019

@fabpot

fabpot approved these changes Jul 3, 2019

@@ -169,8 +169,8 @@ Form
FrameworkBundle
---------------

* Remved the `framework.templating` option, use Twig instead.

This comment has been minimized.

Copy link
@fabpot

fabpot Jul 3, 2019

Member

Removed

This comment has been minimized.

Copy link
@fabpot

This comment has been minimized.

Copy link
@xabbuh

xabbuh Jul 3, 2019

Author Member

thank you 👍

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit ba241ce into symfony:4.3 Jul 3, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 3, 2019

minor #32267 [FrameworkBundle] deprecate the framework.templating opt…
…ion (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] deprecate the framework.templating option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #32120
| License       | MIT
| Doc PR        |

The config node has already been removed in the `master` branch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix.

Commits
-------

ba241ce deprecate the framework.templating option

@xabbuh xabbuh deleted the xabbuh:issue-32120 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.